linux-kernel - Re: [PATCH 1/3] checkpatch: Improve output with multiple command-line files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 04 Jun 2015 05:36:46 -0700
From:	Joe Perches <joe@...ches.com>
To:	Petr Mladek <pmladek@...e.cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...onical.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] checkpatch: Improve output with multiple
 command-line files

On Thu, 2015-06-04 at 14:29 +0200, Petr Mladek wrote:
> On Thu 2015-06-04 05:14:39, Joe Perches wrote:
> > On Thu, 2015-06-04 at 14:03 +0200, Petr Mladek wrote:
> > > On Wed 2015-06-03 08:53:38, Joe Perches wrote:
[]
> > > > +NOTE: Whitespace errors detected.
> > > > +      You may wish to use scripts/cleanpatch or scripts/cleanfile
> > > > +EOM
> > > 
> > > It would make sense to write this message only once as well.
> > 
> > I don't think so as it applies to each patch/file separately.
> 
> IMHO, it advertises scripts/cleanpatch or scripts/cleanfile. I think
> that we do not need to repeat it for each affected patch.

No worries, we just disagree.

> In fact, using scripts/cleanfile is questionable. IMHO, it does not
> make sense to fix indentation just because it looks better. It makes
> problems when backporting fixes. But it might make sense to fix it
> when you do some real change on that line.

Whitespace at EOL backporting is trivially handled by git am.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/