linux-kernel - drm/amdkfd: bad CONFIG_ prefix for enum entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAD3Xx4+ErrNJq9Or6+Gq_ZJ5myyZnnLvAFRCpbhWNmOtHDrraQ@mail.gmail.com>
Date:	Thu, 4 Jun 2015 15:44:43 +0200
From:	Valentin Rothberg <valentinrothberg@...il.com>
To:	yair.shachar@....com
Cc:	Paul Bolle <pebolle@...cali.nl>,
	Andreas Ruprecht <andreas.ruprecht@....de>,
	hengelein Stefan <stefan.hengelein@....de>,
	oded.gabbay@...il.com, airlied@...ux.ie,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: drm/amdkfd: bad CONFIG_ prefix for enum entries

Hi Yair,

your commit fbeb661bfa89 ("drm/amdkfd: Add skeleton H/W debugger
module support") has shown up in today's linux-next tree (i.e.,
next-20150604).  The commit adds the following lines of code to
drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.h:

+/* CONFIG reg space definition */
+enum {
+       CONFIG_REG_BASE = 0x2000,       /* in dwords */
+       CONFIG_REG_END = 0x2B00,
+       CONFIG_REG_SIZE = CONFIG_REG_END - CONFIG_REG_BASE
+};

There is a problem with the 'CONFIG_' prefix of those entries.  This
prefix is reserved for Kconfig options in Make/Kbuild and CPP syntax,
so that static analysis tools (and readers of the code) may mistakenly
assume that the symbol is defined somewhere in a Kconfig file.

I detected the issue with ./scripts/checkkconfigsymbols.py.  Would you
mind renaming those entries to something without the 'CONFIG_' prefix?
 I can also take care of it if you wish to.

Kind regards,
 Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/