[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150604135208.GF28762@mwanda>
Date: Thu, 4 Jun 2015 16:52:08 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Mateusz Kulikowski <mateusz.kulikowski@...il.com>
Cc: gregkh@...uxfoundation.org, joe@...ches.com,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/11] staging: rtl8192e: Remove dead code: rtl_dm.[ch]
On Tue, Jun 02, 2015 at 10:48:10PM +0200, Mateusz Kulikowski wrote:
> - Remove unused fields in dig_t structures. Some of them were only
> initialized and never accessed.
> - Remove unused enums/macros/defines in rtl_dm.h
> - Remove duplicated function declarations
> - Remove unused dm_change_dynamic_initgain_thresh() function
> - Remove unused dm_shadow_init() function
Could you delete dm_shadow[] in a follow on patch.
How I review these sorts of patches is that:
1) Ignore deleted variables. If those are used then it will cause a
compile problem so I don't worry about it.
2) Verify that when we delete initialization, then we also delete the
variable. In this case we deleted the initialization of dm_shadow[]
but not the variable itself, so I wondered if we were using
unitialized data. It turns out that it was just an oversight.
Reviewing these means a lot of searching, for each variable. Next time
if the patch were split up more it would make it a bit easier.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists