[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAC5umyis6HU06KU-aSGoy6mCt-u+5Pz16nDk1qHrcsTnFo_2hA@mail.gmail.com>
Date: Thu, 4 Jun 2015 23:32:16 +0900
From: Akinobu Mita <akinobu.mita@...il.com>
To: Yaniv Gardi <ygardi@...eaurora.org>
Cc: Jej B <James.Bottomley@...senpartnership.com>,
LKML <linux-kernel@...r.kernel.org>,
"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
linux-arm-msm@...r.kernel.org, Santosh Y <santoshsy@...il.com>,
linux-scsi-owner@...r.kernel.org,
Subhash Jadavani <subhashj@...eaurora.org>,
Paul Bolle <pebolle@...cali.nl>,
Gilad Broner <gbroner@...eaurora.org>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Vinayak Holikatti <vinholikatti@...il.com>,
"James E.J. Bottomley" <JBottomley@...n.com>,
Dolev Raviv <draviv@...eaurora.org>,
Christoph Hellwig <hch@....de>,
Sujit Reddy Thumma <sthumma@...eaurora.org>,
Raviv Shvili <rshvili@...eaurora.org>,
Sahitya Tummala <stummala@...eaurora.org>,
"open list:OPEN FIRMWARE AND..." <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from
the platform device
Hi Yaniv,
2015-06-03 18:37 GMT+09:00 Yaniv Gardi <ygardi@...eaurora.org>:
> @@ -321,7 +313,22 @@ static int ufshcd_pltfrm_probe(struct platform_device *pdev)
> goto out;
> }
>
> - hba->vops = get_variant_ops(&pdev->dev);
> + err = of_platform_populate(node, NULL, NULL, &pdev->dev);
> + if (err)
> + dev_err(&pdev->dev,
> + "%s: of_platform_populate() failed\n", __func__);
> +
> + ufs_variant_node = of_get_next_available_child(node, NULL);
> +
> + if (!ufs_variant_node) {
> + dev_dbg(&pdev->dev, "failed to find ufs_variant_node child\n");
> + } else {
> + ufs_variant_pdev = of_find_device_by_node(ufs_variant_node);
> +
> + if (ufs_variant_pdev)
> + hba->vops = (struct ufs_hba_variant_ops *)
> + dev_get_drvdata(&ufs_variant_pdev->dev);
> + }
I have no strong objection to 'ufs_variant' sub-node. But why can't we
simply add an of_device_id to ufs_of_match, like below:
static const struct of_device_id ufs_of_match[] = {
{ .compatible = "jedec,ufs-1.1"},
#if IS_ENABLED(SCSI_UFS_QCOM)
{ .compatible = "qcom,ufs", .data = &ufs_hba_qcom_vops },
#neidf
{},
};
and get hba->vops by get_variant_ops()?
There is something similar in
drivers/net/ethernet/freescale/fsl_pq_mdio.c
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists