linux-kernel - Re: [PATCH v2 2/2] soc: qcom: spm: Fix idle on THUMB2 kernels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150604161510.GS32700@linaro.org>
Date:	Thu, 4 Jun 2015 10:15:10 -0600
From:	Lina Iyer <lina.iyer@...aro.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Kumar Gala <galak@...eaurora.org>,
	Andy Gross <agross@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Kevin Hilman <khilman@...aro.org>,
	Russell King <linux@....linux.org.uk>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>
Subject: Re: [PATCH v2 2/2] soc: qcom: spm: Fix idle on THUMB2 kernels

On Tue, Jun 02 2015 at 13:13 -0600, Stephen Boyd wrote:
>The ifc6410 firmware always enters the kernel in ARM state from
>deep idle. Use the cpu_resume_arm() wrapper instead of
>cpu_resume() to property switch into the THUMB2 state when we
>wake up from idle.
>
>This fixes a problem reported by Kevin Hilman on next-20150601
>where the ifc6410 fails to boot a THUMB2 kernel because the
>platform's firmware always enters the kernel in ARM mode from
>deep idle states.
>
>Reported-by: Kevin Hilman <khilman@...aro.org>
>Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
>Cc: Lina Iyer <lina.iyer@...aro.org>
>Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>

Reviewd-by: Lina Iyer <lina.iyer@...aro.org>

>---
> drivers/soc/qcom/spm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c
>index b562af816c0a..b04b05a0904e 100644
>--- a/drivers/soc/qcom/spm.c
>+++ b/drivers/soc/qcom/spm.c
>@@ -260,7 +260,7 @@ static int __init qcom_cpuidle_init(struct device_node *cpu_node, int cpu)
> 		/* We have atleast one power down mode */
> 		cpumask_clear(&mask);
> 		cpumask_set_cpu(cpu, &mask);
>-		qcom_scm_set_warm_boot_addr(cpu_resume, &mask);
>+		qcom_scm_set_warm_boot_addr(cpu_resume_arm, &mask);
> 	}
>
> 	per_cpu(qcom_idle_ops, cpu) = fns;
>-- 
>The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>a Linux Foundation Collaborative Project
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/