[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55709C98.1030005@intel.com>
Date: Thu, 04 Jun 2015 11:44:40 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Xishi Qiu <qiuxishi@...wei.com>,
Andrew Morton <akpm@...ux-foundation.org>,
nao.horiguchi@...il.com, Yinghai Lu <yinghai@...nel.org>,
"H. Peter Anvin" <hpa@...or.com>,
Thomas Gleixner <tglx@...utronix.de>, mingo@...e.hu,
Xiexiuqi <xiexiuqi@...wei.com>,
Hanjun Guo <guohanjun@...wei.com>,
"Luck, Tony" <tony.luck@...el.com>
CC: Linux MM <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 11/12] mm: add the PCP interface
On 06/04/2015 06:04 AM, Xishi Qiu wrote:
> spin_lock(&zone->lock);
> for (i = 0; i < count; ++i) {
> - struct page *page = __rmqueue(zone, order, migratetype);
> + struct page *page;
> +
> + if (is_migrate_mirror(migratetype))
> + page = __rmqueue_smallest(zone, order, migratetype);
> + else
> + page = __rmqueue(zone, order, migratetype);
> if (unlikely(page == NULL))
> break;
Why is this necessary/helpful? The changelog doesn't tell me either. :(
Why was this code modified in stead of putting the changes in
__rmqueue() itself (like CMA did)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists