linux-kernel - Re: [RFC/PATCH 5/8] drivers/base/core.c: Use strreplace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150604222857.GM7232@ZenIV.linux.org.uk>
Date:	Thu, 4 Jun 2015 23:28:57 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC/PATCH 5/8] drivers/base/core.c: Use strreplace

On Thu, Jun 04, 2015 at 11:37:12AM +0200, Rasmus Villemoes wrote:
> This eliminates a local variable and a little .text.

Hmm...

>  	*tmp = kstrdup(dev_name(dev), GFP_KERNEL);
>  	if (!*tmp)
>  		return NULL;
> -	while ((s = strchr(*tmp, '!')))
> -		s[0] = '/';
> +	strreplace((char *)*tmp, '!', '/');
>  	return *tmp;

That cast isn't nice.  Why not make it
	s = kstrdup(...)
	if (s)
		strreplace(s, ...)
	return *tmp = s;
instead?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/