linux-kernel - Re: [PATCH] added device tree support to gpio-generic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433488647.404966286@f385.i.mail.ru>
Date:	Fri, 05 Jun 2015 10:17:27 +0300
From:	Alexander Shiyan <shc_work@...l.ru>
To:	Romain Baeriswyl <romain.baeriswyl@...tech.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Christian Ruppert 
	<christian.ruppert@...tech.com>,
	Anton Vorontsov <cbouatmailru@...il.com>,
	Rojhalat Ibrahim <imr@...chenk.de>,
	abdoulaye berthe <berthe.ab@...il.com>,
	Anthony Fee <anthony.fee@...tex.com>
Subject: Re: [PATCH] added device tree support to gpio-generic driver

Пятница,  5 июня 2015, 8:51 +02:00 от Romain Baeriswyl <romain.baeriswyl@...tech.com>:
> ---
>  .../devicetree/bindings/gpio/gpio-generic.txt      |   19 +++++
>  drivers/gpio/gpio-generic.c                        |   81 ++++++++++++++-----
>  2 files changed, 78 insertions(+), 22 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-generic.txt

Hello.

...
> diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c
...
> +		if (of_property_read_u32(dev->of_node, "base", &pdata->base))
> +			pdata->base = -1;

The "base" property is excessive for DT.

---