[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150605090200.GL28762@mwanda>
Date: Fri, 5 Jun 2015 12:02:00 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: James Simmons <jsimmons@...radead.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
devel@...verdev.osuosl.org, Oleg Drokin <oleg.drokin@...el.com>,
Andreas Dilger <andreas.dilger@...el.com>,
"John L. Hammond" <john.hammond@...el.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
lustre-devel@...ts.lustre.org
Subject: Re: [PATCH v3 1/8] staging:lustre: assume a kernel build
This whole patchset looks find to me.
Some tips for the future.
On Wed, Jun 03, 2015 at 04:43:20PM -0400, James Simmons wrote:
> From: John L. Hammond <john.hammond@...el.com>
>
> In lnet/lnet/ and lnet/selftest/ assume a kernel build (assume that
> __KERNEL__ is defined). Remove some common code only needed for user
> space LNet.
>
> - recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, LNET_FL_MAX_MES,
> - sizeof(lnet_me_t));
> + recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, 0, 0);
When I'm reviewing "delete code" patches, I pretty much focus on the
plus lines like this one. Obviously, I can figure out why we changed
the parameters to zero but it saves me time if it's spelled out in the
changelog.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists