linux-kernel - Re: [PATCH v2 0/2] Add MediaTek display PWM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433501134.17376.23.camel@mtksdaap41>
Date:	Fri, 5 Jun 2015 18:45:34 +0800
From:	YH Huang <yh.huang@...iatek.com>
To:	Matthias Brugger <matthias.bgg@...il.com>
CC:	Yingjoe Chen <yingjoe.chen@...iatek.com>,
	Thierry Reding <thierry.reding@...il.com>,
	Mark Rutland <mark.rutland@....com>,
	"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
	srv_heupstream <srv_heupstream@...iatek.com>,
	Pawel Moll <pawel.moll@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	"linux-mediatek@...ts.infradead.org" 
	<linux-mediatek@...ts.infradead.org>,
	Sascha Hauer <kernel@...gutronix.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 0/2] Add MediaTek display PWM driver

On Fri, 2015-06-05 at 10:39 +0200, Matthias Brugger wrote:
> Hi YH,
> 
> 2015-06-05 8:15 GMT+02:00 YH Huang <yh.huang@...iatek.com>:
> > On Mon, 2015-05-25 at 10:14 +0800, Yingjoe Chen wrote:
> >> On Thu, 2015-05-21 at 21:29 +0800, YH Huang wrote:
> >
> > This patch series add the use of display PWM driver and documentation
> > for Mediatek SoCs. The driver is used to support the backlight of
> > the panel. This is based on v4.1-rc1.

Change in v2:
1. Rewrite descriptions for driver in kconfig to make it much clear.
2. Rename the driver from "pwm-mediatek-disp" to "pwm-mtk-disp".
3. Disable clocks in the error path.
4. Change the shift values in decimal instead of hex.
5. Rename and add some variables or function name for consistency and
readability.
6. Drop unnecessary parentheses, spaces, variables and add newlines to
make the code easiler to read.

> >
> >> > YH Huang (2):
> >> >   dt-bindings: pwm: add MediaTek display PWM bindings
> >> >   pwm: add MediaTek display PWM driver support
> >> >
> >> >  .../devicetree/bindings/pwm/pwm-mtk-disp.txt       |  25 +++
> >> >  drivers/pwm/Kconfig                                |  10 +
> >> >  drivers/pwm/Makefile                               |   1 +
> >> >  drivers/pwm/pwm-mtk-disp.c                         | 228 +++++++++++++++++++++
> >> >  4 files changed, 264 insertions(+)
> >> >  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> >> >  create mode 100644 drivers/pwm/pwm-mtk-disp.c
> >>
> >> Hi YH,
> >>
> >> It would be easier for reviewer if you have a summary here on what you
> >> have changed compare to last version.
> >> Also, please add patch series summary even for v2, it remind reviewer
> >> what this series is about.
> >>
> >> Joe.C
> >>
> >
> > The patch v2 is refined with everybody's suggestions.
> > It is much readable and consistent.
> 
> I suppose that Yingjoe wanted to emphasis that for the reviewer it is
> much easier if you describe the changes you made from v1 to v2.
> You can find an example (random pick from the mailing list) here:
> http://lists.infradead.org/pipermail/linux-mediatek/2015-May/000572.html
> 
> Thanks,
> Matthias
> 

I have added the change lists.
Thank you.

Regards,
YH Huang


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/