[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150605112443.GA5063@gmail.com>
Date: Fri, 5 Jun 2015 13:24:43 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: umgwanakikbuti@...il.com, mingo@...e.hu, ktkhai@...allels.com,
rostedt@...dmis.org, tglx@...utronix.de, juri.lelli@...il.com,
pang.xunlei@...aro.org, oleg@...hat.com,
wanpeng.li@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/14] sched,lockdep: Employ lock pinning
* Peter Zijlstra <peterz@...radead.org> wrote:
> On Fri, 2015-06-05 at 11:57 +0200, Ingo Molnar wrote:
> > * Peter Zijlstra <peterz@...radead.org> wrote:
> >
> > > Employ the new lockdep lock pinning annotation to ensure no
> > > 'accidental' lock-breaks happen with rq->lock.
> >
> > btw., could we perhaps reorder this series a bit and first see that it
> > properly detects the original locking bug, and then only fix the bug?
> >
> > To make sure the pinning infrastructure works and all that.
>
> It works; I've had plenty explosions while trying to get some of the less
> obvious code paths sorted. I've managed to hit every single WARN I added ;-)
>
> Also, for bisection it might be annoying to hit known bad points, which is why
> its ordered this way.
ok! :-)
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists