linux-kernel - Re: [PATCH 01/27] drm/bridge: ptn3460: #include <linux/gpio/consumer.h>, depend on GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXEMB-_naTr5FRJq6SCT3VhnaNQt-K3LG5cySLKORoPiA@mail.gmail.com>
Date:	Fri, 5 Jun 2015 13:42:13 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	DRI Development <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 01/27] drm/bridge: ptn3460: #include <linux/gpio/consumer.h>,
 depend on GPIOLIB

Hi Thierry,

On Fri, Jun 5, 2015 at 1:20 PM, Thierry Reding <thierry.reding@...il.com> wrote:
> On Tue, May 05, 2015 at 06:32:17PM +0200, Geert Uytterhoeven wrote:
>> If GPIOLIB=n and asm-generic/gpio.h is not used:
>>
>>     drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_pre_enable’:
>>     drivers/gpu/drm/bridge/ptn3460.c:135: error: implicit declaration of function ‘gpiod_set_value’
>>     drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_probe’:
>>     drivers/gpu/drm/bridge/ptn3460.c:333: error: implicit declaration of function ‘devm_gpiod_get’
>>     drivers/gpu/drm/bridge/ptn3460.c:333: warning: assignment makes pointer from integer without a cast
>>     drivers/gpu/drm/bridge/ptn3460.c:340: error: implicit declaration of function ‘gpiod_direction_output’
>>     drivers/gpu/drm/bridge/ptn3460.c:346: warning: assignment makes pointer from integer without a cast
>>
>> Add the missing #include <linux/gpio/consumer.h> to fix this.
>>
>> As the resulting driver won't work with GPIOLIB=n anyway, make
>> DRM_PTN3460 depend on GPIOLIB || COMPILE_TEST.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Cc: David Airlie <airlied@...ux.ie>
>> Cc: dri-devel@...ts.freedesktop.org
>> ---
>>  drivers/gpu/drm/bridge/Kconfig   | 4 ++--
>>  drivers/gpu/drm/bridge/ptn3460.c | 1 +
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> Applied, thanks. Note that I dropped the part about adding the GPIOLIB
> dependency because that had been attempted previously to fix this, but
> it causes recursive dependencies on PowerPC (ppc64_defconfig). I don't
> know of a way to untangle those (I tried and failed miserably), so I
> think adding the include is really as good as it'll get.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/