linux-kernel - Re: [PATCH 1/3] driver: core: add uid gid to class devnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 5 Jun 2015 20:49:58 +0900
From:	'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>
To:	Namjae Jeon <namjae.jeon@...sung.com>
Cc:	'Kay Sievers' <kay@...y.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] driver: core: add uid gid to class devnode

On Fri, Jun 05, 2015 at 08:15:37PM +0900, Namjae Jeon wrote:
> > On Fri, Jun 05, 2015 at 07:10:21PM +0900, Namjae Jeon wrote:
> > > Add support for setting uid gid to devtmpfs device nodes.
> > > In this manner, drivers can specify desired uid gid in their
> > > class->devnode method.
> > >
> > > This is extension of existing method of setting uid gid by drivers
> > > using device_type->devnode method:
> > > 3c2670e6515cf584810f417db9b00992c8b2d75a
> > > "driver core: add uid and gid to devtmpfs"
> > >
> > > Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>
> > > Signed-off-by: Vivek Trivedi <t.vivek@...sung.com>
> > 
> > You add new parameters to these functions, yet never use them.  Sorry, I
> > need an actual user before I can accept api changes like this.
> > 
> > Same for the other 2 patches in this series, I can't accept api changes
> > without a real user of them, otherwise I'll just have to rip them out
> > again to simplify the code.
> Hi Greg,
> 
> In closed embedded systems like Tizen or Android, It is needed to set
> uid/gid and xattr without shell script and daemon like udevd.
> This api change can make it easier to set these parameters

And exactly how will that happen?  I don't see a user of these changes
in the kernel, so I can't accept it, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/