linux-kernel - console setting via stdout-path vs console=xxx (was Re: [PATCH 2/4] ARC: [axs101] support early 8250 uart)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C2D7FE5348E1B147BCA15975FBA23075665A3DF6@IN01WEMBXB.internal.synopsys.com>
Date:	Fri, 5 Jun 2015 13:01:23 +0000
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"Arnd Bergmann" <arnd@...db.de>,
	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
CC:	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"arc-linux-dev@...opsys.com" <arc-linux-dev@...opsys.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Rob Herring <robh@...nel.org>,
	Peter Hurley <peter@...leysoftware.com>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>
Subject: console setting via stdout-path vs console=xxx (was Re: [PATCH 2/4]
 ARC: [axs101] support early 8250 uart)

On Friday 05 June 2015 10:32 AM, Vineet Gupta wrote:
> On Thursday 14 May 2015 06:34 PM, Vineet Gupta wrote:
>> > On Thursday 14 May 2015 06:23 PM, Arnd Bergmann wrote:
>> > 
>> > On Thursday 14 May 2015 15:48:42 Alexey Brodkin wrote:
>> > 
>> > 
>>>> >> >
>>>> >> >         chosen {
>>>> >> > -               bootargs = "console=tty0 console=ttyS3,115200n8 consoleblank=0";
>>>> >> > +               bootargs = "earlycon=uart8250,mmio32,0xe0022000,115200n8 console=tty0 console=ttyS3,115200n8 consoleblank=0";
>>>> >> >         };
>>>> >> >  };
>>>> >> >
>> > 
>> > When you do earlycon with DT, better use a 'stdout-path' property that points
>> > to the device, and just put 'earlycon' without arguments on the command line.
>> > 
>> >         Arnd
>> > 
>> > 
>> > Sure ! I tried that once (3.16) and even the dts patch got merged but had to be reverted out !
>> > 
>> > 2014-07-27 22524b02b17b Revert "ARC: [arcfpga] stdout-path now suffices for earlycon/console"
>> > 
>> > Let me see if that works again since serial land has seen some significant churn in recent times
>> > 
>> > Thx for pointing this out !
> so specifying console with stdout-path works for me,
> 
> -  bootargs = "earlycon=uart8250,mmio32,0xf0000000,115200n8 console=tty0
> console=ttyS0,115200n8 consoleblank=0 debug";
> +  bootargs = "earlycon=uart8250,mmio32,0xf0000000,115200n8";
> +  stdout-path = &uart0;
> ..

Also interestingly, specifying console with stdout-path vs. console=xyz leads to a
subtle behaviour change of boot printing.

With console=xyz, console_setup() -> __add_preferred_console() sets
preferred_console = 0, which doesn't happen with stdout-path.

ARC defconfigs have CONFIG_VT_CONSOLE, so tty0 gets registered. For stdout-path
case it becomes default (deregistering the earlycon), but not in case of cconsole=xyz.

This manifests as a "pause" in boot logging (perceivable if u have linux running
in simulation on a slow host or a large initramfs loading etc). printing is
restored when the real 8250 console registers towards end of boot.

One workaround to this seems to be using @keep_bootcon cmdline option. Asking for
all the bells and whistles to be implemented with paramless earlycon is perhaps
not fair :-)

But this is something developers in this area need to be aware of nevertheless.

Thx,
-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/