linux-kernel - Re: [PATCH -next] MIPS: traps: Add missing include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5571B3B6.9090202@cogentembedded.com>
Date:	Fri, 05 Jun 2015 17:35:34 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Guenter Roeck <linux@...ck-us.net>,
	Ralf Baechle <ralf@...ux-mips.org>
CC:	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] MIPS: traps: Add missing include file

Hello.

On 6/5/2015 5:29 PM, Guenter Roeck wrote:

> Commit 05155ddc2617 ("MIPS: get rid of 'kgdb_early_setup' cruft")
> removed the include of linux/kgdb.h from arch/mips/kernel/traps.c.

    Sorry about that. And thanks for beating me to it. :-)

> This results in

> arch/mips/kernel/traps.c: In function 'show_stack':
> arch/mips/kernel/traps.c:204:14: error: 'kgdb_active' undeclared

    The build robot has informed me about that one...

> arch/mips/kernel/traps.c: In function 'do_trap_or_bp':
> arch/mips/kernel/traps.c:877:2: error:
> 		implicit declaration of function 'kgdb_ll_trap'

    ... but not about this one.

> when building mips:allmodconfig.
>
> Fixes: 05155ddc2617 ("MIPS: get rid of 'kgdb_early_setup' cruft")
> Cc: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/