linux-kernel - Re: [PATCH] tile: add init.h to usb.c to avoid compile failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5571B63A.8040507@windriver.com>
Date:	Fri, 5 Jun 2015 10:46:18 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Chris Metcalf <cmetcalf@...hip.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tile: add init.h to usb.c to avoid compile failure

On 15-06-05 10:42 AM, Chris Metcalf wrote:
> On 06/05/2015 10:36 AM, Paul Gortmaker wrote:
>> Pending header cleanups will reveal this file is using the
>> init.h content implicitly with the following fail:
>>
>> arch/tile/kernel/usb.c:69:1: warning: data definition has no type or storage class [enabled by default]
>> arch/tile/kernel/usb.c:69:1: error: type defaults to 'int' in declaration of 'arch_initcall'
>> arch/tile/kernel/usb.c:69:1: warning: parameter names (without types) in function declaration [enabled by default]
>> arch/tile/kernel/usb.c:62:19: warning: 'tilegx_usb_init' defined but not used
>>
>> Explicitly add init.h to get arch_initcall and avoid this.
>>
>> Reported-by: kbuild test robot<fengguang.wu@...el.com>
>> Cc: Chris Metcalf<cmetcalf@...hip.com>
>> Signed-off-by: Paul Gortmaker<paul.gortmaker@...driver.com>
>> ---
>>
>> [adding this to the header move series of commits; see
>>   https://lkml.kernel.org/r/1433276168-21550-1-git-send-email-paul.gortmaker@windriver.com
>>   for original series posting. ]
>>
>>   arch/tile/kernel/usb.c | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Acked-by: Chris Metcalf <cmetcalf@...hip.com>
> 
> or I'm happy to take it into the tile tree if you'd rather I did.

Thanks, I'll carry it since I'd risk introducing bisection failures
if my header changes go in without this being present 1st.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/