linux-kernel - RE: [PATCH 0/9] Goodix touchscreen enhancements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1F3AC3675D538145B1661F571FE1805F19A79DA1@irsmsx105.ger.corp.intel.com>
Date:	Fri, 5 Jun 2015 16:36:24 +0000
From:	"Tirdea, Irina" <irina.tirdea@...el.com>
To:	'Bastien Nocera' <hadess@...ess.net>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 0/9] Goodix touchscreen enhancements



> -----Original Message-----
> From: Bastien Nocera [mailto:hadess@...ess.net]
> Sent: 04 June, 2015 16:05
> To: Tirdea, Irina
> Cc: Dmitry Torokhov; linux-input@...r.kernel.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 0/9] Goodix touchscreen enhancements
>
> Hey Irina,
>

Hi Bastien,

> On Thu, 2015-05-28 at 15:47 +0300, Irina Tirdea wrote:
> > Add several enhancements to the Goodix touchscreen driver:
> >  - write configuration data to the device
> >  - power management support
> >  - cleanup and refactoring
> >
> > Irina Tirdea (9):
> >   input: goodix: fix alignment issues
> >   input: goodix: fix variable length array warning
> >   input: goodix: export id and version read from device
> >   input: goodix: add ACPI IDs for GT911 and GT9271
> >   input: goodix: reset device at init
> >   input: goodix: write configuration data to device
> >   input: goodix: add power management support
> >   input: goodix: add support for ESD
> >   input: goodix: use goodix_i2c_write_u8 instead of i2c_master_send
>
> Thanks a lot of that patch series. I was travelling when you sent it,
> but I should be able to test the patch series quicker when you send a
> v2.

Thanks for the review and for offering to test the patches. I will send v2 asap.

>
> Could you please also add some references to hardware that you're
> enabling (and presumably have been testing on) to the driver's Kconfig?
> If the hardware is still not public, any sort of other reference would
> be useful (Windows 8 compatible harwdare? Hardware that usually runs a
> particular Android vendor tree?...)

I have been using a custom setup by connecting the touchscreen directly
to a virtual Linux environment through an USB-I2C adapter (https://diolan.com/dln-2).
This is how I could test both ACPI and DT configurations and why the ACPI IDs I used do not
correspond to an actual device.

I have also done tests for the main functionality (writing config, reset, suspend/resume,
ESD) on an Android tablet. Unfortunately the HW is not public and neither is the
Android tree. There is an Android tree publicly available at https://01.org/android-ia,
but it is quite different from the internal tree I am using.

I can add a reference in Kconfig that this driver supports chip models that can be found
on Intel tablets running Android.

Thanks,
Irina

>
> Cheers