linux-kernel - Re: [PATCH] extcon: max77843: Clear IRQ bits state before request IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <55712B64.3090205@samsung.com>
Date:	Fri, 05 Jun 2015 13:53:56 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Jaewon Kim <jaewon02.kim@...sung.com>
Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>,
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH] extcon: max77843: Clear IRQ bits state before request IRQ

Hi Jaewon,

On 06/05/2015 01:32 PM, Jaewon Kim wrote:
> IRQ signal before driver probe is needless because driver sends
> current state after platform booting done.
> So, this patch clears MUIC IRQ bits before request IRQ.
> 
> Signed-off-by: Jaewon Kim <jaewon02.kim@...sung.com>
> ---
>  drivers/extcon/extcon-max77843.c |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
> index d78a64d..11e09d1 100644
> --- a/drivers/extcon/extcon-max77843.c
> +++ b/drivers/extcon/extcon-max77843.c
> @@ -781,6 +781,15 @@ static int max77843_muic_probe(struct platform_device *pdev)
>  	/* Support virtual irq domain for max77843 MUIC device */
>  	INIT_WORK(&info->irq_work, max77843_muic_irq_work);
>  
> +	/* Clear IRQ bits before request IRQs */
> +	ret = regmap_bulk_read(max77843->regmap_muic,
> +			MAX77843_MUIC_REG_INT1, info->status,
> +			MAX77843_MUIC_IRQ_NUM);
> +	if (ret) {
> +		dev_err(&pdev->dev, "Failed to Clear IRQ bits\n");
> +		goto err_muic_irq;
> +	}
> +
>  	for (i = 0; i < ARRAY_SIZE(max77843_muic_irqs); i++) {
>  		struct max77843_muic_irq *muic_irq = &max77843_muic_irqs[i];
>  		unsigned int virq = 0;
> 

Applied it.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/