linux-kernel - Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blockslinux-kernel@...r.kernel.org,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 6 Jun 2015 17:35:08 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Aparna Karuthodi <kdasaparna@...il.com>
Cc:	gregkh@...uxfoundation.org, lidza.louina@...il.com,
	devel@...verdev.osuosl.org, driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not
 necessary for single statement blockslinux-kernel@...r.kernel.org,

Send the patch to yourself.  Apply it with git am.  Review the git log
and then send it to the list.

But actually this change is not correct at all.  The prefered style in
staging is that multi-line indent blocks get curly braces for
readability even when they are not required by the compiler.  The patch
introduces other coding style violations.  Did you run checkpatch.pl
over it?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/