[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 6 Jun 2015 09:19:03 -0700
From: Jean-Baptiste Theou <jtheou@...neo-embedded.us>
To: Paul Bolle <pebolle@...cali.nl>
CC: Valentin Rothberg <valentinrothberg@...il.com>,
Wim Van Sebroeck <wim@...ana.be>,
Guenter Roeck <linux@...ck-us.net>,
<linux-watchdog@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] gpio_wdt: Add option for early registration
Thanks for the feedback.
I tested a version before cleanup, and the mistake was introduce during it.
It's my mistake, sorry about that. Will fix it on v4.
On Sat, 6 Jun 2015 16:11:18 +0200
Paul Bolle <pebolle@...cali.nl> wrote:
> On Sat, 2015-06-06 at 14:56 +0200, Valentin Rothberg wrote:
> > On Sat, Jun 06, 2015 at 12:03:06PM +0200, Paul Bolle wrote:
> > > On Sat, 2015-06-06 at 00:46 -0700, Jean-Baptiste Theou wrote:
> > > > +#ifdef GPIO_WATCHDOG_ARCH_INITCALL
> > >
> > > You meant
> > > #ifdef CONFIG_GPIO_WATCHDOG_ARCH_INITCALL
> > >
> > > Please use scripts/checkkconfigsymbols.py.
> >
> > checkkconfigsymbols.py only checks CONFIG_ prefix symbols. Since this
> > prefix is missing here, the script would not complain.
>
> Of course. Thanks for correcting me.
>
> > But that's an interesting case and worth checking for.
>
> Perhaps. Depends on the amount of false positives that such checks would
> trigger, I'd say.
>
>
> Paul Bolle
>
--
Jean-Baptiste Theou <jtheou@...neo-embedded.us>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists