lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 7 Jun 2015 00:58:54 +0200 From: Oleg Nesterov <oleg@...hat.com> To: Jiri Kosina <jkosina@...e.cz> Cc: Petr Mladek <pmladek@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>, Tejun Heo <tj@...nel.org>, Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, Richard Weinberger <richard@....at>, Steven Rostedt <rostedt@...dmis.org>, David Woodhouse <dwmw2@...radead.org>, linux-mtd@...ts.infradead.org, Trond Myklebust <trond.myklebust@...marydata.com>, Anna Schumaker <anna.schumaker@...app.com>, linux-nfs@...r.kernel.org, Chris Mason <clm@...com>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, Thomas Gleixner <tglx@...utronix.de>, Linus Torvalds <torvalds@...ux-foundation.org>, Borislav Petkov <bp@...e.de>, Michal Hocko <mhocko@...e.cz>, live-patching@...r.kernel.org, linux-api@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [RFC PATCH 11/18] jffs2: Convert jffs2_gcd_mtd kthread into the iterant API On 06/07, Jiri Kosina wrote: > > On Sun, 7 Jun 2015, Oleg Nesterov wrote: > > > > I personally don't see a huge principal difference between > > > "kthread_signal_dequeue() + kthread_do_signal_{stop,...}" vs. generic > > > "kthread_do_signal()" that's just basically completely general and > > > takes care of 'everything necessary'. > > > > Then why do we need the new API ? > > Well, in a nutshell, because of the "it's general and takes care of > everything" part. ... > Signal handling is just > one of the piggy-backers on top of this general cleanup. And to avoid the confusion: so far I only argued with the signal handling part of this API. Namely with kthread_do_signal(), especially with the SIG_DFL logic. If we want somthing like kthread_iterant agree it should probably help to handle the signals too. But afaics kthread_do_signal() doesn't really help and certainly it is not strictly necessary. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists