linux-kernel - Re: [PATCH v5 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 6 Jun 2015 13:58:33 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Sanchayan Maity <maitysanchayan@...il.com>
Cc:	arnd@...db.de, shawn.guo@...aro.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	stefan@...er.ch, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes

Hi,

On Fri, Jun 05, 2015 at 02:52:37PM +0530, Sanchayan Maity wrote:
> Add a device tree node for the On-Chip One Time Programmable
> Controller (OCOTP) and the On-Chip ROM.
> 
> Signed-off-by: Sanchayan Maity <maitysanchayan@...il.com>
> ---
>  arch/arm/boot/dts/vfxxx.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 2f4b04d..ed9b6b8 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -56,6 +56,13 @@
>  		compatible = "simple-bus";
>  		interrupt-parent = <&mscm_ir>;
>  		ranges;
> +		ocotp-cfg = <&ocotp 0x410 0x420>;
> +		rom-revision = <&ocrom 0x80>;
> +
> +		ocrom: ocrom {
> +			compatible = "fsl,vf610-ocrom", "syscon";
> +			reg = <0x00000000 0x18000>;
> +		};

Shouldn't that use the new nvmem framework currently being discussed,
instead of defining custom bindings?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)