linux-kernel - Re: [PATCH 1/2] iio: adc: twl4030_madc: Fix calculation of the temperature sense current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <206BDE24-37FF-496B-861E-5356132EDB4C@goldelico.com>
Date:	Sun, 7 Jun 2015 18:33:28 +0200
From:	"Dr. H. Nikolaus Schaller" <hns@...delico.com>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	Marek Belisko <marek@...delico.com>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: twl4030_madc: Fix calculation of the temperature sense current


Am 07.06.2015 um 18:25 schrieb Jonathan Cameron <jic23@...nel.org>:

> On 28/05/15 20:50, Marek Belisko wrote:
>> From: "H. Nikolaus Schaller" <hns@...delico.com>
>> 
>> The bit mask to read the setting of the constant current source
>> for measuring the NTC voltage was the wrong one. Since default
>> value is initialized to the lowest level (000 = 10uA) the difference
>> was probably never noticed in practice.
> I'm going to take that literally and apply it via the slow route on
> the basis that a bug no one noticed doesn’t need fixing fast!

Yes, that is fine.

>> 
>> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
>> Signed-off-by: Marek Belisko <marek@...delico.com>
> Applied to the togreg branch of iio.git - initially pushed out as
> testing for the autobuilders to play with it.
> 
> Thanks,
> 
> Jonathan

Thanks,
Nikolaus

>> ---
>> drivers/iio/adc/twl4030-madc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c
>> index 94c5f05..6d2d429 100644
>> --- a/drivers/iio/adc/twl4030-madc.c
>> +++ b/drivers/iio/adc/twl4030-madc.c
>> @@ -235,7 +235,7 @@ static int twl4030battery_temperature(int raw_volt)
>> 	if (ret < 0)
>> 		return ret;
>> 
>> -	curr = ((val & TWL4030_BCI_ITHEN) + 1) * 10;
>> +	curr = ((val & TWL4030_BCI_ITHSENS) + 1) * 10;
>> 	/* Getting and calculating the thermistor resistance in ohms */
>> 	res = volt * 1000 / curr;
>> 	/* calculating temperature */
>> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/