linux-kernel - Re: [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 07 Jun 2015 21:28:45 +0200
From:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
CC:	gregkh@...uxfoundation.org, joe@...ches.com,
	devel@...verdev.osuosl.org, dan.carpenter@...cle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode

On 04.06.2015 08:06, Sudip Mukherjee wrote:
> On Thu, Jun 04, 2015 at 07:50:07AM +0200, Mateusz Kulikowski wrote:
>> On 04.06.2015 07:18, Sudip Mukherjee wrote:
>>> On Wed, Jun 03, 2015 at 08:21:02PM +0200, Mateusz Kulikowski wrote:
>>>> On 03.06.2015 09:26, Sudip Mukherjee wrote:
>>>>> On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikowski wrote:
>>>>
>>>> No, I missed that - this one should also be removed - probably because of similar naming (DbgMode, dbg_mode).
>>>> Thanks for finding it - I'll fix that in v2.
>>>>
>>>> Apart from that - did you had time/courage to analyze rest of the patches (so I can send v2)?
>>>
>>> at a first glance looked ok to me. I hope you have checked it on the
>>> hardware as well. but maybe Dan can find something.
>>> better send v2.
>>
>> Of course I have checked it, although - as I wrote in past - this driver has not very good performance.
> is there any other driver which has better performance on this hardware
> than this driver? and how are you measuring the performance?

What I meant is that this driver (at least on my HW/SW configuration) is not very reliable.

It drops a lot of packages and transmission speed is far from declared.
But - as far as I checked - it's not due to my changes (I checked that some time ago).

Perhaps my hardware has some issues - I have to buy another rtl8192e card and/or test on Windows 
to be sure (will do both steps probably).

As for measurement, I have simple tests on my home network (WPA2/CCMP):
- Scan available networks
- Download 1MB file, check md5
- Ping router/gateway

Regards,
Mateusz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/