linux-kernel - Re: [PATCH v3 1/2] net/xen-netfront: Correct printf format in xennet_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150607.020005.1921032930953172020.davem@davemloft.net>
Date:	Sun, 07 Jun 2015 02:00:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	julien.grall@...rix.com
Cc:	xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
	david.vrabel@...rix.com, konrad.wilk@...cle.com,
	boris.ostrovsky@...cle.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3 1/2] net/xen-netfront: Correct printf format in
 xennet_get_responses

From: Julien Grall <julien.grall@...rix.com>
Date: Thu, 4 Jun 2015 16:35:13 +0100

> rx->status is an int16_t, print it using %d rather than %u in order to
> have a meaningful value when the field is negative.
> 
> Also use %d rather than %x for rx->offset.
> 
> Signed-off-by: Julien Grall <julien.grall@...rix.com>
> Reviewed-by: David Vrabel <david.vrabel@...rix.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> Cc: netdev@...r.kernel.org
> 
> ---
>     Changes in v3:
>         - Use %d for the rx-offset too.

This change in v3 is wrong, 'rx->offset' is unsigned therefore %u is
the correct format string to use.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/