linux-kernel - Re: [PATCH] ARM: tegra: roth: Add MMC pwrseq to power wifi on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABxcv=kBcr7g77jj98KQ19R_oaoTrVGjqDgQa6ghZz7CJ+t3uw@mail.gmail.com>
Date:	Mon, 8 Jun 2015 10:12:06 +0200
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Alexandre Courbot <acourbot@...dia.com>
Cc:	Thierry Reding <thierry.reding@...il.com>,
	Stephen Warren <swarren@...dotorg.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Alexandre Courbot <gnurou@...il.com>
Subject: Re: [PATCH] ARM: tegra: roth: Add MMC pwrseq to power wifi on

Hello Alexandre,

On Mon, Jun 8, 2015 at 9:41 AM, Alexandre Courbot <acourbot@...dia.com> wrote:
> The wifi chip on roth needs to have its reset deasserted in order to be
> probed. Add a mmc-pwrseq-simple to allow this to happen and get wifi
> working at boot time.
>
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
> ---
>  arch/arm/boot/dts/tegra114-roth.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/tegra114-roth.dts b/arch/arm/boot/dts/tegra114-roth.dts
> index ea1772a686c2..04762532a178 100644
> --- a/arch/arm/boot/dts/tegra114-roth.dts
> +++ b/arch/arm/boot/dts/tegra114-roth.dts
> @@ -972,6 +972,11 @@
>                 nvidia,invert-interrupt;
>         };
>
> +       sdhci0_pwrseq: sdhci0_pwrseq {
> +               compatible = "mmc-pwrseq-simple";
> +               reset-gpios = <&gpio TEGRA_GPIO(CC, 5) GPIO_ACTIVE_LOW>;
> +       };
> +
>         /* Wifi */
>         sdhci@...00000 {
>                 status = "okay";
> @@ -979,6 +984,7 @@
>                 broken-cd;
>                 keep-power-in-suspend;
>                 cap-sdio-irq;
> +               mmc-pwrseq = <&sdhci0_pwrseq>;
>         };
>
>         /* SD card */

I'm neither familiar with this board nor have a schematic but the
patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/