linux-kernel - Re: [PATCH 1/4] x86/asm/entry: Rename compat syscall entry points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150608084740.GA3612@pd.tnic>
Date:	Mon, 8 Jun 2015 10:47:40 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Andy Lutomirski <luto@...capital.net>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Brian Gerst <brgerst@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/4] x86/asm/entry: Rename compat syscall entry points

On Mon, Jun 08, 2015 at 10:34:58AM +0200, Ingo Molnar wrote:
> Rename the following system call entry points:
> 
> 	ia32_cstar_target       -> entry_SYSCALL_compat
> 	ia32_syscall            -> entry_INT80_compat
> 
> The generic naming scheme for x86 system call entry points is:
> 
> 	entry_MNEMONIC_qualifier
> 
> where 'qualifier' is one of _32, _64 or _compat.
> 
> Cc: Andy Lutomirski <luto@...capital.net>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Brian Gerst <brgerst@...il.com>
> Cc: Denys Vlasenko <dvlasenk@...hat.com>
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> ---
>  Documentation/x86/entry_64.txt   | 4 ++--
>  arch/x86/entry/entry_64_compat.S | 8 ++++----
>  arch/x86/entry/syscall_32.c      | 6 +++---
>  arch/x86/include/asm/proto.h     | 4 ++--
>  arch/x86/kernel/asm-offsets_64.c | 2 +-
>  arch/x86/kernel/cpu/common.c     | 2 +-
>  arch/x86/kernel/traps.c          | 2 +-
>  arch/x86/xen/xen-asm_64.S        | 2 +-
>  8 files changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/Documentation/x86/entry_64.txt b/Documentation/x86/entry_64.txt
> index 9132b86176a3..33884d156125 100644
> --- a/Documentation/x86/entry_64.txt
> +++ b/Documentation/x86/entry_64.txt
> @@ -18,10 +18,10 @@ The IDT vector assignments are listed in arch/x86/include/asm/irq_vectors.h.
>  
>   - system_call: syscall instruction from 64-bit code.
>  
> - - ia32_syscall: int 0x80 from 32-bit or 64-bit code; compat syscall
> + - entry_INT80_compat: int 0x80 from 32-bit or 64-bit code; compat syscall
>     either way.

Haha, with the new naming scheme you don't even need the text anymore.
entry_INT80_compat is already enough.

:-)

Looks like an improvement to me, at a quick glance.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/