linux-kernel - Re: [RFT v2 11/48] ipu: Use irq_desc_get_xxx() to avoid redundant lookup of irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150608111658.GL28601@localhost>
Date:	Mon, 8 Jun 2015 16:46:58 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Jiang Liu <jiang.liu@...ux.intel.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	Yinghai Lu <yinghai@...nel.org>,
	Borislav Petkov <bp@...en8.de>,
	Dan Williams <dan.j.williams@...el.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Steve Longerbeam <slongerbeam@...il.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Tony Luck <tony.luck@...el.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-acpi@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [RFT v2 11/48] ipu: Use irq_desc_get_xxx() to avoid redundant
 lookup of irq_desc

On Thu, Jun 04, 2015 at 12:13:21PM +0800, Jiang Liu wrote:
> Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc while we
> already have a pointer to corresponding irq_desc.
> 
> Do the same thing to avoid pattern "irq_get_chip_data(data->irq)".

And I am missing the context, it is a bad practice to send some part of the
series without giving context. Is this dependent on something else...?

-- 
~Vinod
> 
> Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com>
> ---
>  drivers/dma/ipu/ipu_irq.c       |    2 +-
>  drivers/gpu/ipu-v3/ipu-common.c |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/ipu/ipu_irq.c b/drivers/dma/ipu/ipu_irq.c
> index 2e284a4438bc..0e12af37fe2f 100644
> --- a/drivers/dma/ipu/ipu_irq.c
> +++ b/drivers/dma/ipu/ipu_irq.c
> @@ -268,7 +268,7 @@ int ipu_irq_unmap(unsigned int source)
>  /* Chained IRQ handler for IPU error interrupt */
>  static void ipu_irq_err(unsigned int irq, struct irq_desc *desc)
>  {
> -	struct ipu *ipu = irq_get_handler_data(irq);
> +	struct ipu *ipu = irq_desc_get_handler_data(desc);
>  	u32 status;
>  	int i, line;
>  
> diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
> index 67bab5c36056..7022825b7a2c 100644
> --- a/drivers/gpu/ipu-v3/ipu-common.c
> +++ b/drivers/gpu/ipu-v3/ipu-common.c
> @@ -915,8 +915,8 @@ static void ipu_irq_handle(struct ipu_soc *ipu, const int *regs, int num_regs)
>  static void ipu_irq_handler(unsigned int irq, struct irq_desc *desc)
>  {
>  	struct ipu_soc *ipu = irq_desc_get_handler_data(desc);
> +	struct irq_chip *chip = irq_desc_get_chip(desc);
>  	const int int_reg[] = { 0, 1, 2, 3, 10, 11, 12, 13, 14};
> -	struct irq_chip *chip = irq_get_chip(irq);
>  
>  	chained_irq_enter(chip, desc);
>  
> @@ -928,8 +928,8 @@ static void ipu_irq_handler(unsigned int irq, struct irq_desc *desc)
>  static void ipu_err_irq_handler(unsigned int irq, struct irq_desc *desc)
>  {
>  	struct ipu_soc *ipu = irq_desc_get_handler_data(desc);
> +	struct irq_chip *chip = irq_desc_get_chip(desc);
>  	const int int_reg[] = { 4, 5, 8, 9};
> -	struct irq_chip *chip = irq_get_chip(irq);
>  
>  	chained_irq_enter(chip, desc);
>  
> -- 
> 1.7.10.4
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/