lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 8 Jun 2015 11:20:39 +0000
From:	Appana Durga Kedareswara Rao <appana.durga.rao@...inx.com>
To:	Paul Bolle <pebolle@...cali.nl>
CC:	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"vinod.koul@...el.com" <vinod.koul@...el.com>,
	Michal Simek <michals@...inx.com>,
	Soren Brinkmann <sorenb@...inx.com>,
	"Punnaiah Choudary Kalluri" <punnaia@...inx.com>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Srikanth Thokala <sthokal@...inx.com>
Subject: RE: [PATCH v6] dma: Add Xilinx AXI Direct Memory Access Engine
 driver support

Hi Paul,


> -----Original Message-----
> From: Paul Bolle [mailto:pebolle@...cali.nl]
> Sent: Friday, May 22, 2015 3:40 PM
> To: Appana Durga Kedareswara Rao
> Cc: dan.j.williams@...el.com; vinod.koul@...el.com; Michal Simek; Soren
> Brinkmann; Appana Durga Kedareswara Rao; Punnaiah Choudary Kalluri;
> dmaengine@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; Srikanth Thokala
> Subject: Re: [PATCH v6] dma: Add Xilinx AXI Direct Memory Access Engine
> driver support
>
> Just a nit: a license mismatch.
>
> On Thu, 2015-05-21 at 22:37 +0530, Kedareswara rao Appana wrote:
> > --- /dev/null
> > +++ b/drivers/dma/xilinx/xilinx_dma.c
>
> > + * This program is free software: you can redistribute it and/or
> > + modify
> > + * it under the terms of the GNU General Public License as published
> > + by
> > + * the Free Software Foundation, either version 2 of the License, or
> > + * (at your option) any later version.
>
> This states the license is GPL v2 or later.
>
> > +MODULE_LICENSE("GPL v2");
>
> And, according to include/linux/module.h, this states the license is just GPL
> v2. So I think that either the comment at the top of this file or the ident used
> in the MODULE_LICENSE() macro needs to change.
>

Ok Will fix it in the next version of the patch.

Regards,
Kedar.

> Thanks,
>
>
> Paul Bolle



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ