linux-kernel - RE: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Jun 2015 11:38:47 +0000
From:	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Kosina <jkosina@...e.cz>, DT <devicetree@...r.kernel.org>,
	David Dajun Chen <david.chen@...semi.com>,
	INPUT <linux-input@...r.kernel.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Lee Jones <lee.jones@...aro.org>,
	"Mark Rutland" <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	"Support Opensource" <Support.Opensource@...semi.com>,
	"Opensource [Adam Ward]" <Adam.Ward.opensource@...semi.com>
Subject: RE: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver

On 05 June 2015 18:50 Dmitry Torokhov wrote:

> Subject: Re: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver
> On Thu, Jun 04, 2015 at 12:02:32PM +0100, S Twiss wrote:
> > From: Steve Twiss <stwiss.opensource@...semi.com>
> >
> > Add OnKey driver support for DA9063
> >
> > Signed-off-by: Steve Twiss <stwiss.opensource@...semi.com>
> >
> > ---
> > The changes made in PATCH V3 have been taken from the DA9062 OnKey review
> > thread. Please see https://lkml.org/lkml/2015/4/29/406 for more information
> > on this.
> >
> > Version History
> >
> > Changes in V4
> >  - No change, just a resend.
> 
> Sorry for the delay.
> 
> I took the liberty of rearranging the code a bit and converting it to
> devm* fully, does the version below still work for you?
> 

Hi Dmitry,

No problem. Thank you for getting back to me and for taking the time to work
through this code.

Everything looks fine for me thank you.

Tested-by: Steve Twiss <stwiss.opensource@...semi.com>

I see now: in future I will make use of the devm_add_action() and use the devm*
properly & your changes have simplified the error handling and negated the need
for a .remove function. The devm release cleans up in reverse -- preserving
the free_irq() and cancel_delayed_work_sync() ordering ...

Regards,
Steve.

CC: Adam Ward <adam.ward.opensource@...semi.com>

[...]

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/