linux-kernel - Re: [PATCH] x86/asm/entry/32: Reinstate clearing of pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <557590DC.8050703@redhat.com>
Date:	Mon, 08 Jun 2015 14:55:56 +0200
From:	Denys Vlasenko <dvlasenk@...hat.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Borislav Petkov <bp@...en8.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andy Lutomirski <luto@...capital.net>,
	Oleg Nesterov <oleg@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Will Drewry <wad@...omium.org>,
	Kees Cook <keescook@...omium.org>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/asm/entry/32: Reinstate clearing of pt_regs->r8..r11
 on EFAULT path

On 06/08/2015 08:50 AM, Ingo Molnar wrote:
> * Denys Vlasenko <dvlasenk@...hat.com> wrote:
> 
>> I broke this recently when I changed pt_regs->r8..r11 clearing logic
>> in INT 80 code path.
>>
>> There is a branch from SYSENTER/SYSCALL code to INT 80 code:
>> if we fail to retrieve arg6, we return EFAULT. Before this patch,
>> in this case we don't clear pt_regs->r8..r11.
>>
>> This patch fixes this. The resulting code is smaller and simpler.
> 
> So how did you notice this bug - through actual info leak testing, or review?

By reviewing my own patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/