linux-kernel - Re: [RFC][PATCH] regmap: make REGCACHE_NONE maps return error on regcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150608172451.GJ14071@sirena.org.uk>
Date:	Mon, 8 Jun 2015 18:24:51 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Nariman Poushin <nariman@...nsource.wolfsonmicro.com>
Cc:	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH] regmap: make REGCACHE_NONE maps return error on
 regcache_sync

On Mon, Jun 08, 2015 at 03:16:41PM +0100, Nariman Poushin wrote:

> In light of this:
> https://lkml.org/lkml/2015/6/7/193

Please provide human readable descriptions for things, people don't
always read online and it at least means going to another program to
figure out what's being discussed.

> Would it be prudent to now  make these WARN_ON? It seems like it's not
> worth taking the kernel down in the case where you are trying to sync to
> a non-existent cache for a peripheral. Of course it could be that the 

This is nothing new on Linus' part, really - as he himself says.  We're
being cautious here because we are often controlling devices like PMICs
and battery chargers where we're worried about physically damaging the
system if we get things too wrong, one thing that might possibly have
been happening here is that we've got very confused about what we're
doing with a critical system component.  There's certainly a case for
having some handling that's less severe but it does need to be something
that people notice and which is conservative about interacting with the
device after it noticed the problem.

In any case, if you want to propose a code change then please submit a
patch.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)