| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150608195455.GF5222@piout.net> Date: Mon, 8 Jun 2015 21:54:55 +0200 From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> To: Paul Gortmaker <paul.gortmaker@...driver.com> Cc: linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org, Alessandro Zummo <a.zummo@...ertech.it>, rtc-linux@...glegroups.com Subject: Re: [42/73] rtc: delete non-required instances of include <linux/init.h> On 21/01/2014 at 16:22:45 -0500, Paul Gortmaker wrote : > None of these files are actually using any __init type directives > and hence don't need to include <linux/init.h>. Most are just a > left over from __devinit and __cpuinit removal, or simply due to > code getting copied from one driver to the next. > > Cc: Alessandro Zummo <a.zummo@...ertech.it> > Cc: rtc-linux@...glegroups.com > Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com> I've contemplated applying that patch but I'm not sure it is actually a good idea because those 46 drivers are using a variant of module_driver which actually uses __init and __exit. After your patch it is still working simply because init.h gets included that way: linux/module.h:9 linux/list.h:8 linux/kernel.h:13 linux/printk.h:5 -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists