linux-kernel - Re: [PATCH v4 1/7] staging:lustre: move tcpip abstraction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433793469.2730.5.camel@perches.com>
Date:	Mon, 08 Jun 2015 12:57:49 -0700
From:	Joe Perches <joe@...ches.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org
Cc:	James Simmons <jsimmons@...radead.org>, devel@...verdev.osuosl.org,
	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	lustre-devel@...ts.lustre.org
Subject: Re: [PATCH v4 1/7] staging:lustre: move tcpip abstraction

On Mon, 2015-06-08 at 12:33 -0700, Greg Kroah-Hartman wrote:
> Please generate patches in -M format, so I can see the rename properly,
> as it is, this is too messy for me to review.

Adding this to the .gitconfig works too

[diff]
	renames = true

That should probably be mentioned in SubmittingPatches.

Something like:
---
 Documentation/SubmittingPatches | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 27e7e5e..d86cf89 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -715,6 +715,13 @@ the top of the kernel source tree and don't use too much horizontal
 space (easily fit in 80 columns, maybe with some indentation).  (git
 generates appropriate diffstats by default.)
 
+Another good thing is to generate shorter patches whenever a file rename
+has been done.  Using "git format-patch -M" does this appropriately.
+Adding a [diff] section as below to .gitconfig can also do this:
+
+       [diff]
+              renames = true
+
 See more details on the proper patch format in the following
 references.
 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/