linux-kernel - Re: [PATCH v3] Staging: rtl8192e: Casting correct Endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150608204153.GA17791@kroah.com>
Date:	Mon, 8 Jun 2015 13:41:53 -0700
From:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:	"DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@...teon.com>
Cc:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"mdcasey@...bloom.com" <mdcasey@...bloom.com>,
	"behanw@...verseincode.com" <behanw@...verseincode.com>,
	"mateusz.kulikowski@...il.com" <mateusz.kulikowski@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] Staging: rtl8192e: Casting correct Endianness

On Tue, Jun 02, 2015 at 03:59:32PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> From: Gnanachandran Dhanapal <gdhanapa@...teon.com>
> 
> Casting correct Endianness for __le16 variable used in assignment and
> condition check
> 
> Signed-off-by: Gnanachandran Dhanapal <gdhanapa@...teon.com>
> ---
> v3: Greg review comments addressed
> 
> ---
>  drivers/staging/rtl8192e/rtllib_softmac.c |   14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 9dce121..a842170 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -1265,7 +1265,7 @@ inline struct sk_buff *rtllib_association_req(struct rtllib_network *beacon,
>  		skb_put(skb, sizeof(struct rtllib_assoc_request_frame) + 2);
>  
>  
> -	hdr->header.frame_ctl = RTLLIB_STYPE_ASSOC_REQ;
> +	hdr->header.frame_ctl = cpu_to_le16(RTLLIB_STYPE_ASSOC_REQ);
>  	hdr->header.duration_id = cpu_to_le16(37);
>  	ether_addr_copy(hdr->header.addr1, beacon->bssid);
>  	ether_addr_copy(hdr->header.addr2, ieee->dev->dev_addr);
> @@ -2244,8 +2244,10 @@ inline int rtllib_rx_assoc_resp(struct rtllib_device *ieee, struct sk_buff *skb,
>  	struct rtllib_assoc_response_frame *assoc_resp;
>  	struct rtllib_hdr_3addr *header = (struct rtllib_hdr_3addr *) skb->data;
>  
> +	u16 frame_ctl = le16_to_cpu(header->frame_ctl);
> +

Why the blank line before this variable definition?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/