linux-kernel - Re: [PATCH] atm: use msecs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150608.155425.1095846044935528227.davem@davemloft.net>
Date:	Mon, 08 Jun 2015 15:54:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hofrat@...dl.org
Cc:	3chas3@...il.com, linux-atm-general@...ts.sourceforge.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: use msecs_to_jiffies for conversions

From: Nicholas Mc Guire <hofrat@...dl.org>
Date: Mon,  8 Jun 2015 21:16:28 +0200

> API compliance scanning with coccinelle flagged:
> ./drivers/atm/iphase.c:2621:4-20:
>         WARNING: timeout (50) seems HZ dependent
> 
> Numeric constants passed to schedule_timeout() make the effective
> timeout HZ dependent which does not seem intended.
> Fixed up by converting the constant to jiffies with msecs_to_jiffies()
> As this driver was introduced in the early 2.3 series it is most 
> likely assuming HZ=100 so the constant 50 is converted to 500ms.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/