lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 09 Jun 2015 01:42 +0200 From: "Rafael J. Wysocki" <rjw@...ysocki.net> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: linux-acpi@...r.kernel.org, linux-pm@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Vinod Koul <vinod.koul@...el.com>, Lee Jones <lee.jones@...aro.org>, Andrew Morton <akpm@...ux-foundation.org>, Mika Westerberg <mika.westerberg@...ux.intel.com>, linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Jarkko Nikula <jarkko.nikula@...ux.intel.com>, "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>, Mike Turquette <mturquette@...aro.org> Subject: Re: [PATCH v3 3/8] Driver core: wakeup the parent device before trying probe On Monday, June 01, 2015 05:47:57 PM Andy Shevchenko wrote: > From: Heikki Krogerus <heikki.krogerus@...ux.intel.com> > > If the parent is still suspended when driver probe is > attempted, the result may be failure. > > For example, if the parent is a PCI MFD device that has been > suspended when we try to probe our device, any register > reads will return 0xffffffff. > > To fix the problem, making sure the parent is always awake > before attempting driver probe. > > Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> > --- > drivers/base/dd.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/base/dd.c b/drivers/base/dd.c > index e843fdb..cfbeff3 100644 > --- a/drivers/base/dd.c > +++ b/drivers/base/dd.c > @@ -399,6 +399,8 @@ EXPORT_SYMBOL_GPL(wait_for_device_probe); > * > * This function must be called with @dev lock held. When called for a > * USB interface, @dev->parent lock must be held as well. > + * > + * If device has a parent it will be powered on during device's probe(). > */ > int driver_probe_device(struct device_driver *drv, struct device *dev) > { > @@ -410,10 +412,16 @@ int driver_probe_device(struct device_driver *drv, struct device *dev) > pr_debug("bus: '%s': %s: matched device %s with driver %s\n", > drv->bus->name, __func__, dev_name(dev), drv->name); > > + if (dev->parent) > + pm_runtime_get_sync(dev->parent); > + For some bus types that will resume and suspend the parent for many times in a row in device_attach() until an appropriate driver is found. Would it be more efficient to call it once before the bus_for_each_drv() loop in there? > pm_runtime_barrier(dev); > ret = really_probe(dev, drv); > pm_request_idle(dev); > > + if (dev->parent) > + pm_runtime_put_sync(dev->parent); Is there anything particularly wrong with calling pm_runtime_put() here instead? > + > return ret; > } > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists