linux-kernel - Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1506090808500.2069@localhost6.localdomain6>
Date:	Tue, 9 Jun 2015 08:10:58 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Michal Simek <monstr@...str.eu>
cc:	Paul Bolle <pebolle@...cali.nl>,
	Kedareswara rao Appana <appana.durga.rao@...inx.com>,
	dan.j.williams@...el.com, vinod.koul@...el.com,
	michal.simek@...inx.com, soren.brinkmann@...inx.com,
	appanad@...inx.com, punnaia@...inx.com, dmaengine@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Srikanth Thokala <sthokal@...inx.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access
 Engine driver support



On Tue, 9 Jun 2015, Michal Simek wrote:

> Hi Paul,
> 
> On 05/22/2015 12:30 PM, Paul Bolle wrote:
> > Again, just a nit: a license mismatch.
> > 
> > On Thu, 2015-05-21 at 22:37 +0530, Kedareswara rao Appana wrote:
> > 
> >> + * This program is free software: you can redistribute it and/or modify
> >> + * it under the terms of the GNU General Public License as published by
> >> + * the Free Software Foundation, either version 2 of the License, or
> >> + * (at your option) any later version.
> > 
> >> +MODULE_LICENSE("GPL v2");
> > 
> > As I said in the message I sent a short while ago: here too I think that
> > either the comment at the top of this file or the ident used in the
> > MODULE_LICENSE() macro needs to change.
> 
> This is not just the problem with this driver but with others too.
> Have you sent any patch to add GPL v2+ to license.h?
> 
> Also sort of checking for this will be great. Julia?

If this requires checking the contents of comment, Coccinelle currently 
can't help with that.  Perhaps an idea would be to just do a grep on the 
file.  So if I find MODULE_LICENSE("GPL v2") and then grepping for "either 
vresion 2" gives success, then there is a problem?  It's obviously not 
foolproof, but perhaps it could be helpful.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/