linux-kernel - Re: [PATCH v5 12/21] libnvdimm: namespace indices: read and validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150609063900.GD9804@lst.de>
Date:	Tue, 9 Jun 2015 08:39:00 +0200
From:	Christoph Hellwig <hch@....de>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	linux-nvdimm@...ts.01.org, axboe@...nel.dk, sfr@...b.auug.org.au,
	rafael@...nel.org, neilb@...e.de, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, mingo@...nel.org,
	linux-acpi@...r.kernel.org, jmoyer@...hat.com,
	linux-api@...r.kernel.org, akpm@...ux-foundation.org, hch@....de
Subject: Re: [PATCH v5 12/21] libnvdimm: namespace indices: read and
	validate

> +#include <asm-generic/io-64-nonatomic-lo-hi.h>
> +
> +#ifndef __io_virt
> +#define __io_virt(x) ((void __force *) (x))
> +#endif

NAK. driver code mus never include asm-generic headers directly,
and __io_virt isn't something that's up to a driver to redefine either.

I think we really need the memremap series in first before trying to
do the things done in this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/