linux-kernel - RE: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Jun 2015 07:21:46 +0000
From:	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>
To:	Lee Jones <lee.jones@...aro.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	DT <devicetree@...r.kernel.org>,
	David Dajun Chen <david.chen@...semi.com>,
	INPUT <linux-input@...r.kernel.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Mark Rutland" <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Support Opensource <Support.Opensource@...semi.com>
Subject: RE: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver

On 09 June 2015 07:51 Lee Jones wrote:

> On Mon, 08 Jun 2015, Dmitry Torokhov wrote:
> > On Tue, May 19, 2015 at 11:32:45AM +0100, S Twiss wrote:
> > > From: Steve Twiss <stwiss.opensource@...semi.com>
> > >
> > > Add MFD support for the DA9063 OnKey driver
> > >
> > > The function da9063_clear_fault_log() is added to mitigate the case of a
> > > hardware power-cut after a long-long OnKey press. Although there is no
> > > software intervention in this case (by definition) such a shutdown would
> > > cause persistent information within the DA9063 FAULT_LOG that would be
> > > available during the next device restart.
> > >
> > > Clearance of this persistent register must be completed after such a
> > > hardware power-cut operation has happened so that the FAULT_LOG does not
> > > continue with previous values. The clearance function has been added here
> > > in the kernel driver because wiping the fault-log cannot be counted on
> > > outside the Linux kernel.
> > >
> > > Acked-by: Lee Jones <lee.jones@...aro.org>
> > >
> > > Signed-off-by: Steve Twiss <stwiss.opensource@...semi.com>
> >
> > ...
> >
> > > diff --git a/include/linux/mfd/da9063/pdata.h
> b/include/linux/mfd/da9063/pdata.h
> > > index 95c8742..612383b 100644
> > > --- a/include/linux/mfd/da9063/pdata.h
> > > +++ b/include/linux/mfd/da9063/pdata.h
> > > @@ -103,6 +103,7 @@ struct da9063;
> > >  struct da9063_pdata {
> > >  	int				(*init)(struct da9063 *da9063);
> > >  	int				irq_base;
> > > +	bool				key_power;
> > >  	unsigned			flags;
> > >  	struct da9063_regulators_pdata	*regulators_pdata;
> > >  	struct led_platform_data	*leds_pdata;
> >
> > I need this bit of pdata to merge the OnKey driver... Lee, any chance
> > you could drop it from the patch in your tree?
> 
> Consider it done.
> 
> > Alternatively, can you pick the OnKey driver (the latest version is
> > below)?
> >
> > Thanks.
> >

Thank you both for your help.
Regards,
Steve