linux-kernel - Re: [42/73] rtc: delete non-required instances of include <linux/init.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150609074946.GG5222@piout.net>
Date:	Tue, 9 Jun 2015 09:49:46 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com
Subject: Re: [42/73] rtc: delete non-required instances of include
 <linux/init.h>

On 08/06/2015 at 17:06:34 -0400, Paul Gortmaker wrote :
> > I've contemplated applying that patch but I'm not sure it is actually a
> > good idea because those 46 drivers are using a variant of module_driver
> > which actually uses __init and __exit. After your patch it is still
> > working simply because init.h gets included that way:
> 
> Firstly, I am kind of curious why an 18 month old patch is getting
> replied to now.   That aside, this interdependence between module.h and
> init.h was reconsidered and you can see the resolution solution here:
> 
> https://lkml.kernel.org/r/1433276168-21550-1-git-send-email-paul.gortmaker@windriver.com
> 
> To summarize what is said there, yes - you can ignore the one line
> removals for now.  We will revisit them after the above is merged.
> 

I've taken the RTC subsystem maintainership and I've been sorting the
2372 patches left in patchwork down to 126 and yours was one of these.

Seeing your answer, I think my question was legitimate. I'll be happy to
take your revised patch once ready.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/