linux-kernel - Re: [PATCH 4/8] mfd: htc-i2cpld: Pass the IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150609075538.GJ2982@x1>
Date:	Tue, 9 Jun 2015 08:55:38 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Fabio Estevam <festevam@...il.com>
Cc:	Julia.Lawall@...6.fr, linux-kernel@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH 4/8] mfd: htc-i2cpld: Pass the IRQF_ONESHOT flag

On Sat, 16 May 2015, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@...escale.com>
> 
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
> 
> So pass the IRQF_ONESHOT flag in this case.
> 
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> ---
>  drivers/mfd/htc-i2cpld.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
> index ebb9cf1..b54baad 100644
> --- a/drivers/mfd/htc-i2cpld.c
> +++ b/drivers/mfd/htc-i2cpld.c
> @@ -564,7 +564,8 @@ static int htcpld_core_probe(struct platform_device *pdev)
>  		htcpld->chained_irq = res->start;
>  
>  		/* Setup the chained interrupt handler */
> -		flags = IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING;
> +		flags = IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING |
> +			IRQF_ONESHOT;
>  		ret = request_threaded_irq(htcpld->chained_irq,
>  					   NULL, htcpld_handler,
>  					   flags, pdev->name, htcpld);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/