linux-kernel - Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433837720.16887.42.camel@x220>
Date:	Tue, 09 Jun 2015 10:15:20 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	monstr@...str.eu
Cc:	Julia Lawall <julia.lawall@...6.fr>,
	Kedareswara rao Appana <appana.durga.rao@...inx.com>,
	dan.j.williams@...el.com, vinod.koul@...el.com,
	michal.simek@...inx.com, soren.brinkmann@...inx.com,
	appanad@...inx.com, punnaia@...inx.com, dmaengine@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Srikanth Thokala <sthokal@...inx.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Joe Perches <joe@...ches.com>,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access
 Engine driver support

On Tue, 2015-06-09 at 09:09 +0200, Michal Simek wrote:
> On 06/09/2015 08:10 AM, Julia Lawall wrote:
> > On Tue, 9 Jun 2015, Michal Simek wrote:
> >> Also sort of checking for this will be great. Julia?
> > 
> > If this requires checking the contents of comment, Coccinelle currently 
> > can't help with that.  Perhaps an idea would be to just do a grep on the 
> > file.  So if I find MODULE_LICENSE("GPL v2") and then grepping for "either 
> > vresion 2" gives success, then there is a problem?  It's obviously not 
> > foolproof, but perhaps it could be helpful.
> 
> Having some sort of checking somewhere will be great. checkpatch?
> zero-day testing system?

Mistakes I've seen made since I started checking this stuff (a few
months ago):
- typos in the license ident, say "GPLv2", "GPL V2", or "BSD": generates
a warning when module is loaded and taints kernel. People still get this
wrong. A test in checkpatch for these typos was submitted a while ago,
but it never got added;
- not adding MODULE_LICENSE() to a module: also generates a warning when
module is loaded and taints kernel. People still get this wrong;
- adding MODULE_LICENSE() to built-in only code: pointless at best, and
annoying for reviewers ("Hey, did the submitter intend to write built-in
only code or modular code?");
- using "Dual BSD/GPL" but not a trace of the BSD license blurb in
sight, while adding that blurb is one of the very few requirements this
license actually has;
- license mismatch, say comment blurb states "GPL v2 (or later)" but
MODULE_LICENSE() ident states "GPL v2" only (or vice versa): very easy
mistake to make, happens once or twice a week.  

Did I miss anything in that list?

I'm afraid that most of the above can only be caught reliably by
attention to detail by submitters and reviewers. That's a pity, because
checking for that stuff is about as boring as it gets. (What does that
say about me?)

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/