linux-kernel - Re: [PATCH] hid: Add secondary vendor id for the marco, USB_DEVICE_ID_MS_TYPE_COVER_3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADscph3L+t4=T2+o3JXgRVEDn+Cfj7+sQE2s2MDgBCCZRmDUqQ@mail.gmail.com>
Date:	Tue, 9 Jun 2015 10:39:25 +0200
From:	Daniel Martin <consume.noise@...il.com>
To:	Alan Wu <alan.c.wu@...il.com>
Cc:	Jiri Kosina <jkosina@...e.cz>,
	Nicholas Krause <xerofoify@...il.com>,
	linux-input <linux-input@...r.kernel.org>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] hid: Add secondary vendor id for the marco, USB_DEVICE_ID_MS_TYPE_COVER_3_V2

On 21 May 2015 at 04:40, Alan Wu <alan.c.wu@...il.com> wrote:
> Hello Jiri,
>   I believe the patch may work, but I would rename the IDs.  Obviously
> I can't test Surface 3 non-Pro cover, but the difference is likely due
> to the following:
>
> This is 0x07dc (I do own)
> http://www.microsoftstore.com/store/msusa/en_US/pdp/Surface-Pro-Type-Cover/productID.300193600
>
> This is 0x07de (I do not own)
> http://www.microsoftstore.com/store/msusa/en_US/pdp/Surface-3-Type-Cover/productID.314885800
>
> I would rename 0x07dc to USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 (original
> submitted patch)
> and 0x07de to USB_DEVICE_ID_MS_TYPE_COVER_3 (Nicholas' patch).
>
> I would probably also rename 0x07dd to USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP.

I've got another Type Cover 3 (0x07e2 ) here, where I was going to
send a patch for. According to the small picture, it looks like a
0x07de - grey, not that glossy keys.

How should I name the define? Won't it be better to append the model
number to distinguish the Type Covers?
I've got a 0x07dc (model 1644) and 0x07e2 (model 1709).
... USB_DEVICE_ID_MS_TYPE_COVER_3_M1644
... USB_DEVICE_ID_MS_TYPE_COVER_3_M1709

The model number (pretty small) can be found on the connector above
the CE sign on the right.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/