linux-kernel - Re: [PATCH v9 5/6] arm64: dts: Add dts files for Hisilicon Hi6220 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150609005521.GA21682@tiger>
Date:	Tue, 9 Jun 2015 08:55:21 +0800
From:	Shawn Guo <shawnguo@...nel.org>
To:	Bintian Wang <bintian.wang@...wei.com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	catalin.marinas@....com, will.deacon@....com,
	devicetree@...r.kernel.org, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, khilman@...aro.org, mturquette@...aro.org,
	rob.herring@...aro.org, zhangfei.gao@...aro.org,
	haojian.zhuang@...aro.org, xuwei5@...ilicon.com,
	jh80.chung@...sung.com, olof@...om.net, yanhaifeng@...il.com,
	sboyd@...eaurora.org, xuejiancheng@...wei.com,
	sledge.yanwei@...wei.com, tomeu.vizoso@...labora.com,
	linux@....linux.org.uk, guodong.xu@...aro.org,
	jorge.ramirez-ortiz@...aro.org, tyler.baker@...aro.org,
	khilman@...nel.org, pebolle@...cali.nl, arnd@...db.de,
	marc.zyngier@....com, dan.zhao@...ilicon.com, huxinwei@...wei.com,
	xuyiping@...ilicon.com, wangbintian@...il.com,
	victor.lixin@...ilicon.com, puck.chen@...ilicon.com,
	wangbinghui@...ilicon.com, zhenwei.wang@...ilicon.com,
	liguozhu@...ilicon.com, kong.kongxinwei@...ilicon.com,
	heyunlei@...wei.com, w.f@...wei.com, z.liuxinliang@...wei.com
Subject: Re: [PATCH v9 5/6] arm64: dts: Add dts files for Hisilicon Hi6220 SoC

A minor random comment below.

On Sat, May 30, 2015 at 09:51:00AM +0800, Bintian Wang wrote:
> +		ao_ctrl: ao_ctrl {
> +			compatible = "hisilicon,hi6220-aoctrl", "syscon";
> +			reg = <0x0 0xf7800000 0x0 0x2000>;
> +			#clock-cells = <1>;
> +		};
> +
> +		sys_ctrl: sys_ctrl {
> +			compatible = "hisilicon,hi6220-sysctrl", "syscon";
> +			reg = <0x0 0xf7030000 0x0 0x2000>;
> +			#clock-cells = <1>;
> +		};
> +
> +		media_ctrl: media_ctrl {
> +			compatible = "hisilicon,hi6220-mediactrl", "syscon";
> +			reg = <0x0 0xf4410000 0x0 0x1000>;
> +			#clock-cells = <1>;
> +		};
> +
> +		pm_ctrl: pm_ctrl {

An unit-address should be coded in the node name, when it has a 'reg'
property.

Shawn

> +			compatible = "hisilicon,hi6220-pmctrl", "syscon";
> +			reg = <0x0 0xf7032000 0x0 0x1000>;
> +			#clock-cells = <1>;
> +		};
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/