linux-kernel - Re: [PATCH kmod 3/3] tools: display features together with version information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKi4VALwFnq2RBFxkwVAq6JbE58JmorofL73x7R_cW1Yy4o2Cg@mail.gmail.com>
Date:	Mon, 8 Jun 2015 22:42:06 -0300
From:	Lucas De Marchi <lucas.de.marchi@...il.com>
To:	Andreas Mohr <andi@...as.de>
Cc:	linux-modules <linux-modules@...r.kernel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Bertrand Jacquin <beber@...eeweb.net>,
	"Marco d'Itri" <md@...ux.it>, lkml <linux-kernel@...r.kernel.org>,
	Kay Sievers <kay@...y.org>,
	Lucas De Marchi <lucas.demarchi@...el.com>
Subject: Re: [PATCH kmod 3/3] tools: display features together with version information

On Sun, Jun 7, 2015 at 6:17 AM, Andreas Mohr <andi@...as.de> wrote:
> Hi,
>
> On Sun, Jun 07, 2015 at 03:27:29AM -0300, lucas.de.marchi@...il.com wrote:
>> From: Lucas De Marchi <lucas.demarchi@...el.com>
>> diff --git a/tools/kmod.c b/tools/kmod.c
>> index c9d2cc8..28217df 100644
>> --- a/tools/kmod.c
>> +++ b/tools/kmod.c
>> @@ -114,6 +114,7 @@ static int handle_kmod_commands(int argc, char *argv[])
>>                       return EXIT_SUCCESS;
>>               case 'V':
>>                       puts("kmod version " VERSION);
>> +                     puts(KMOD_FEATURES);
>>                       return EXIT_SUCCESS;
>
> Hmm - seems kmod.c is the only component
> which open-codes literals
> rather than making use of PACKAGE define?
> If this is not intended,
> then it would probably be useful
> to have another correction commit prior to this one
> included in the series,
> to have this one gain properly fully symmetric content.

Indeed. I just added a commit doing that and pushed to master.

thanks

-- 
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/