linux-kernel - Re: [tpmdd-devel] [PATCH v2] tpm: introduce struct tpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Jun 2015 12:32:57 +0200
From:	Peter Huewe <peterhuewe@....de>
To:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
CC:	"moderated list:TPM DEVICE DRIVER" 
	<tpmdd-devel@...ts.sourceforge.net>, safford@...ibm.com,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [tpmdd-devel] [PATCH v2] tpm: introduce struct tpm_buf



Hi

>> > +static inline void tpm_buf_store(struct tpm_buf *buf,
>> > +				 unsigned int pos,
>> > +				 const unsigned char *data,
>> > +				 unsigned int len)
>> > +{
>> > +	BUG_ON((pos + len) > TPM_BUF_SIZE);
>> > +
>> > +	memcpy(&buf->data[pos], data, len);
>> > +}
>> 
>> Don't you have to update the ->length here?
>
>No. Store is for placing value in position, not appending to the end.
>
Then either add a length check (whether ->length is big enough) and/or call the function "update"

Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/