linux-kernel - Re: [PATCH 09/15] KVM: MTRR: introduce var_mtrr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <557651BF.5060900@linux.intel.com>
Date:	Tue, 09 Jun 2015 10:38:55 +0800
From:	Xiao Guangrong <guangrong.xiao@...ux.intel.com>
To:	David Matlack <dmatlack@...gle.com>
CC:	Paolo Bonzini <pbonzini@...hat.com>,
	Gleb Natapov <gleb@...nel.org>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	kvm list <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 09/15] KVM: MTRR: introduce var_mtrr_range


Thanks for your review, David!


On 06/09/2015 08:36 AM, David Matlack wrote:

>>   static void update_mtrr(struct kvm_vcpu *vcpu, u32 msr)
>>   {
>>          struct kvm_mtrr *mtrr_state = &vcpu->arch.mtrr_state;
>> -       gfn_t start, end, mask;
>> +       gfn_t start, end;
>>          int index;
>>
>>          if (msr == MSR_IA32_CR_PAT || !tdp_enabled ||
>> @@ -244,11 +255,7 @@ static void update_mtrr(struct kvm_vcpu *vcpu, u32 msr)
>>          default:
>>                  /* variable range MTRRs. */
>>                  index = (msr - 0x200) / 2;
>> -               start = mtrr_state->var_ranges[index].base & PAGE_MASK;
>> -               mask = mtrr_state->var_ranges[index].mask & PAGE_MASK;
>> -               mask |= ~0ULL << cpuid_maxphyaddr(vcpu);
>
> Why did you drop this in favor of boot_cpu_data.x86_phys_bits?
>

It can make the code more generic, @vcpu is not needed anymore.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/