[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150609031144.GB12655@saruman.tx.rr.com>
Date: Mon, 8 Jun 2015 22:11:44 -0500
From: Felipe Balbi <balbi@...com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Colin King <colin.king@...onical.com>,
Felipe Balbi <balbi@...com>,
Sudeep Holla <sudeep.holla@....com>,
Valentin Rothberg <Valentin.Rothberg@...6.fr>,
<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][V3] usb: isp1760: check for null return from kzalloc
On Mon, Jun 08, 2015 at 02:22:06PM -0700, Greg Kroah-Hartman wrote:
> On Wed, Jun 03, 2015 at 03:43:23AM +0300, Laurent Pinchart wrote:
> > Hi Colin,
> >
> > Thank you for the patch.
> >
> > On Tuesday 02 June 2015 19:05:13 Colin King wrote:
> > > From: Colin Ian King <colin.king@...onical.com>
> > >
> > > isp1760_ep_alloc_request allocates a structure with kzalloc without checking
> > > for NULL and then returns a pointer to one of the structure fields. As the
> > > field happens to be the first in the structure the caller can properly
> > > check for NULL, but this is risky if the structure layout is changed later.
> > > Add an explicit NULL check for the kzalloc return value
> > >
> > > Detected with smatch static analysis:
> > >
> > > drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request()
> > > error: potential null dereference 'req'. (kzalloc returns null)
> > >
> > > [ thanks to Laurent Pinchart for improved commit message ]
> > >
> > > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> >
> > Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> >
> > Felipe, I expect you to pick this up, please let me know if there's any issue.
>
> I'll just take it directly, thanks.
that works too, dropping from my queue.
--
balbi
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)
Powered by blists - more mailing lists