linux-kernel - Re: [PATCH RFC] crypto: drbg - lower reseed threshold if seed source is degraded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150609153328.GA16954@gondor.apana.org.au>
Date:	Tue, 9 Jun 2015 23:33:28 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Stephan Mueller <smueller@...onox.de>
Cc:	andreas.steffen@...ongswan.org, Ted Tso <tytso@....edu>,
	sandyinchina@...il.com, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] crypto: drbg - lower reseed threshold if seed source
 is degraded

On Tue, Jun 09, 2015 at 05:27:46PM +0200, Stephan Mueller wrote:
>
> I see one: the reset of the threshold to the "normal" value must happen at two 
> places: the one place is in the async handler. The 2nd place is when the 
> request to random.c returns 0 (i.e. fully initialized). The 2nd location is 
> different between both code bases.

Right but after the callback patch there should be only one location
where you reset it to normal, namely in the async handler.  The
other place would only set it to the lower value if the pool is
not ready yet.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/